chore: Create flag migration #6356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Zaimwa9 <wadii.zaim@flagsmith.com>
# Conflicts: # frontend/web/components/pages/UserPage.tsx
talissoncosta
requested changes
Jan 20, 2026
Contributor
talissoncosta
left a comment
talissoncosta
left a comment
There was a problem hiding this comment.
I’ve noticed some unusual behavior during the QA session and would like to clarify it before moving forward.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Contributor
|
V1 not requesting CR to update segment overrides |
talissoncosta
approved these changes
Jan 20, 2026
talissoncosta
added a commit
that referenced
this pull request
Jan 23, 2026
… override The 'Enabled by default' toggle and its tooltip were incorrectly shown when editing an identity override. This was a regression introduced in PR #6356 where the CreateFeature component was extracted with isEdit hardcoded to false. When editing an identity override, isEdit should be true so that: - The toggle shows 'Enabled' instead of 'Enabled by default' - The tooltip about initial enabled state is not shown Fixes #6580 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
How did you test this code?
E2E covers regression testing on everything this affects