Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
074f8f9 to
f466b13
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6452 +/- ##
==========================================
+ Coverage 98.18% 98.19% +0.01%
==========================================
Files 1294 1297 +3
Lines 46994 47001 +7
==========================================
+ Hits 46141 46153 +12
+ Misses 853 848 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4daf736 to
bafcaff
Compare
matthewelwell
commented
Jan 2, 2026
Contributor
Author
matthewelwell
left a comment
There was a problem hiding this comment.
Minor comments for context where needed.
api/app_analytics/migrations/0007_rename_environment_id_created_at_index.py
Show resolved
Hide resolved
api/users/migrations/0045_add_through_fields_metadata_for_django_5_upgrade.py
Show resolved
Hide resolved
Contributor
Docker builds report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Depends on:
deps: update django to 5.2.9 flagsmith-common#149Upgrade to django 5.
There were seemingly very few changes that were needed, and most of the updates in this PR relate to typing updates which I've tried to fix where possible but erred on the side of
type: ignorecomments where needed.The main breaking changes that required handling on our end were:
Model.Meta.index_togetherwas removed. I've replaced usages of this withmodels.Index(fields=[...]). This change does result in a migration applied to the database in the form of aRenameIndexbut from what I can tell, this is a very minor operation and doesn't require any locks on the data in the table, or the index, only on the metadata for the table.django.utils.timezone.utcwas removed. I've replaced this withdatetime.timezone.utc, but since we still want to usedjango.utils.timezonefor other logic, (e.g.timezone.now()), I've importeddatetime.timezoneasdttzwhere needed.I also had to update a few dependencies to support the django upgrade:
Note that the upgrade of django-debug-toolbar meant that I needed to remove
DEBUG = Truefrom the test settings (conversation on the actual LoC for clarification).How did you test this code?
Unit tests, and running locally.