Skip to content

Conversation

@talissoncosta
Copy link
Contributor

@talissoncosta talissoncosta commented Jan 24, 2026

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Closes #6592

UI cleanup for the tab overflow dropdown menu in the feature modal.

Problem: The dropdown menu items (Code References, Links, History, Settings) displayed with extra whitespace before the text and inconsistent purple backgrounds due to the TabButton component being unnecessarily used inside the dropdown.

Solution: Simplified the dropdown menu items to use tabLabel directly instead of wrapping it in a TabButton component. This removes:

  • Unnecessary wrapper div with flexbox styling
  • TabButton component with its own button styling
  • Complex className combinations causing visual inconsistencies

How did you test this code?

  1. Open a feature modal with many tabs (so some overflow into dropdown)
  2. Click the overflow menu button (three dots icon)
  3. Verify menu items display cleanly without extra whitespace
  4. Verify active tab is highlighted with primary colour text
  5. Verify clicking a menu item correctly switches to that tab

Remove unnecessary TabButton wrapper from dropdown menu items in the
Tabs component. The previous implementation caused styling issues with
extra whitespace and inconsistent backgrounds. Now uses the tabLabel
directly as the menu item label.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@vercel
Copy link

vercel bot commented Jan 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment Jan 24, 2026 2:06am
flagsmith-frontend-staging Ready Ready Preview, Comment Jan 24, 2026 2:06am
1 Skipped Deployment
Project Deployment Review Updated (UTC)
docs Ignored Ignored Jan 24, 2026 2:06am

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(frontend): Tab overflow dropdown menu has styling issues

2 participants