fix(Segments): delete_segment task crashes when segment already deleted

[bardock-2393]

The async delete_segment task fetches a segment by id and deletes it, but a concurrent delete of the same segment (e.g. a cascading project or feature delete racing with another delete of the same segment) can remove it first. The task then crashes with Segment.DoesNotExist instead of treating the segment as already gone.

Changes

• delete_segment task no longer crashes when the segment was already removed by a concurrent delete
• Added regression tests covering both the normal delete and the already-deleted case

Closes #7354

Review effort: 1/5

[vercel]

@bardock-2393 is attempting to deploy a commit to the Flagsmith Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 394881b5-0cb1-4a32-b5d4-5ac04cfb22ad

📥 Commits

Reviewing files that changed from the base of the PR and between 1201efd and d156f71.

📒 Files selected for processing (2)

• api/segments/tasks.py
• api/tests/unit/segments/test_unit_segments_tasks.py

---

📝 Walkthrough

Walkthrough

The segment deletion task now catches Segment.DoesNotExist and treats missing segments as a no-op. Unit tests cover soft deletion of an existing segment and repeated invocation after hard deletion.

Estimated code review effort: 1 (Trivial) | ~5 minutes

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}