Skip to content

Split live-status tracking into its own subscriber (and share one MQTT connection) - Part 2: Add LiveStatusSubscriber#7844

Merged
cstns merged 11 commits into
mainfrom
7608-split-live-status
Jul 21, 2026
Merged

Split live-status tracking into its own subscriber (and share one MQTT connection) - Part 2: Add LiveStatusSubscriber#7844
cstns merged 11 commits into
mainfrom
7608-split-live-status

Conversation

@n-lark

@n-lark n-lark commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Description

Gives live status its own LiveStatusSubscriber instead of bundling it into the team-channel subscriber, and has the two share one team MQTT connection (using the attach/detach from PR 1) rather than each needing its own.

Cut from #7843

See test plan: #7608 (comment)

Related Issue(s)

Resolves #7608

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@n-lark
n-lark requested a review from cstns July 16, 2026 18:12
@n-lark n-lark self-assigned this Jul 16, 2026
@n-lark n-lark changed the title Split live-status into its own subscriber sharing the team MQTT conne… Split live-status tracking into its own subscriber (and share one MQTT connection) - Part 2: Add LiveStatusSubscriber Jul 16, 2026
Comment thread frontend/src/subscribers/team-subscriber.contract.ts
@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.08264% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.61%. Comparing base (56c95c3) to head (f55f01c).
⚠️ Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
forge/ee/lib/sso/index.js 79.10% 14 Missing ⚠️
forge/lib/nonceStore.js 87.50% 5 Missing ⚠️
forge/ee/routes/expert/index.js 94.33% 3 Missing ⚠️
...orge/db/migrations/20260714-01-add-audit-source.js 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7844      +/-   ##
==========================================
+ Coverage   75.11%   75.61%   +0.49%     
==========================================
  Files         430      432       +2     
  Lines       22846    23035     +189     
  Branches     6055     6107      +52     
==========================================
+ Hits        17160    17417     +257     
+ Misses       5686     5618      -68     
Flag Coverage Δ
backend 75.61% <90.08%> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cstns cstns left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The only thing i'd like to touch base on is the naming issue I mentioned on the pr this is based off of.

Other than that, happy to merge

@n-lark
n-lark requested a review from cstns July 17, 2026 16:43
Base automatically changed from 7608-mqtt-shared-connection to main July 21, 2026 07:55
@cstns
cstns merged commit 5802322 into main Jul 21, 2026
27 checks passed
@cstns
cstns deleted the 7608-split-live-status branch July 21, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Split live-status tracking into its own subscriber (and share one MQTT connection)

2 participants