Fix templatePathAndFilename and requestFilter in Readme#34
Open
anianweber wants to merge 3 commits intoFlowpack:mainfrom
Open
Fix templatePathAndFilename and requestFilter in Readme#34anianweber wants to merge 3 commits intoFlowpack:mainfrom
anianweber wants to merge 3 commits intoFlowpack:mainfrom
Conversation
Fix the path for `templatePathAndFilename` to be the same as the the original template. The original template is located under `.../Authentication/Index.html` and **not** under `.../Authenticate/Index.html`, so as you copy the original template into your own package one might miss the difference (as I have done).
anianweber
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the path for
templatePathAndFilenameto be the same as the the original template. The original template is located under.../Authentication/Index.htmland not under.../Authenticate/Index.html, so as you copy the original template into your own package one might miss the difference (as I have done).Also i have fixed the
requestFilterin the Readme to be the same as the actual implementedrequestFilter(otherwise the override of the template won't work)