Skip to content

Fix cross channel videos link sometimes broken#8276

Merged
FreeTubeBot merged 7 commits intoFreeTubeApp:developmentfrom
PikachuEXE:fix/local-cross-channel-author-link
Jan 25, 2026
Merged

Fix cross channel videos link sometimes broken#8276
FreeTubeBot merged 7 commits intoFreeTubeApp:developmentfrom
PikachuEXE:fix/local-cross-channel-author-link

Conversation

@PikachuEXE
Copy link
Copy Markdown
Member

@PikachuEXE PikachuEXE commented Nov 13, 2025

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Description

There are some cross channel (cross 2 channels) videos and sometimes the handling is faulty (already handled sometimes)
Like having channel links with channel ID like N/A or empty string and if you click it you see no such channel message
This PR fixes those missing places

Screenshots

Testing

Local API + IV API

  • Search for Moore's Law Is Dead and Ancient Gameplays, Look for Nvidia RTX 5080 SUPER Cancelled? AMD RX 9080 XT & RDNA 5 🧐 | Ancient Gameplays | Broken Silicon 335, ensure no channel link (no way to infer)
  • Add that video to a user playlist, ensure no link shown in playlist
  • Visit the channel https://www.youtube.com/channel/UCRPdsCVuH53rcbTcEkuY4uQ (one of the channels of above video), ensures above video shown with link (back to the same page)
  • Subscribe the channel and refresh sub, ensure above video shown with link to channel page

Desktop

  • OS:
  • OS Version:
  • FreeTube version:

Additional context

IV got no channel link for those videos which might or might not be improved in this PR (not a.t.m. of writing)
Update 1: Fixed IV API to be the same as local API

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) November 13, 2025 01:36
@github-actions github-actions Bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 13, 2025
@PikachuEXE PikachuEXE force-pushed the fix/local-cross-channel-author-link branch from b2b1788 to 9af908f Compare November 13, 2025 01:51
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Copy Markdown
Member

Im a bit confused about this PR. What does it solve? Maybe add before and after screenshots so my Magikarp brain understands

@PikachuEXE
Copy link
Copy Markdown
Member Author

Oh before fix you see links with channel ID like N/A or empty string and if you click it you see no such channel message
Added to description

@github-actions github-actions Bot added PR: merge conflicts / rebase needed and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Nov 17, 2025
* development: (22 commits)
  Workaround ready-to-show not firing consistently on wayland (FreeTubeApp#8294)
  Bump electron from 38.4.0 to 39.2.1 (FreeTubeApp#8303)
  Migrate the WatchVideoInfo component to the composition API (FreeTubeApp#8295)
  Translated using Weblate (Hungarian)
  Translated using Weblate (Norwegian Bokmål)
  Translated using Weblate (French)
  Bump eslint-plugin-jsdoc from 61.1.12 to 61.2.1 in the eslint group (FreeTubeApp#8298)
  Replace broken trending with a local API only equivalent (FreeTubeApp#8289)
  Fix settings layout issues after the Vue 3 migration (FreeTubeApp#8292)
  Bump lefthook from 2.0.3 to 2.0.4 (FreeTubeApp#8299)
  Bump shaka-player from 4.16.8 to 4.16.9 (FreeTubeApp#8301)
  Bump electron-builder from 26.1.0 to 26.2.0 (FreeTubeApp#8302)
  Fix playlist video view counts on the local API (FreeTubeApp#8290)
  change hardcoded color app text logoColor (FreeTubeApp#8288)
  Translated using Weblate (Russian)
  Translated using Weblate (German)
  wrap long playlist strings (FreeTubeApp#8275)
  Translated using Weblate (Bulgarian)
  Bump js-yaml from 4.1.0 to 4.1.1 (FreeTubeApp#8284)
  bump workflows node-version to 24 (FreeTubeApp#8279)
  ...

# Conflicts:
#	src/renderer/helpers/api/invidious.js
* development: (123 commits)
  Translated using Weblate (Slovak)
  Translated using Weblate (Slovak)
  Translated using Weblate (Slovak)
  add skip to previous/next video buttons in media player (FreeTubeApp#8285)
  Translated using Weblate (Slovak)
  Translated using Weblate (Slovak)
  Translated using Weblate (German)
  Bump express from 4.21.2 to 4.22.0 (FreeTubeApp#8374)
  Bump electron-builder from 26.3.0 to 26.3.2 (FreeTubeApp#8370)
  Translated using Weblate (Hebrew)
  Bump the eslint group with 2 updates (FreeTubeApp#8367)
  Translated using Weblate (Portuguese)
  Bump stylelint from 16.26.0 to 16.26.1 in the stylelint group (FreeTubeApp#8368)
  Bump vue-i18n from 11.1.12 to 11.2.2 (FreeTubeApp#8369)
  Bump electron from 39.2.3 to 39.2.4 (FreeTubeApp#8371)
  Bump mikefarah/yq from 4.49.1 to 4.49.2 (FreeTubeApp#8372)
  Translated using Weblate (Slovak)
  Translated using Weblate (Slovak)
  Translated using Weblate (Slovak)
  Translated using Weblate (Slovak)
  ...
* development: (62 commits)
  Support exporting single playlists in YouTube's CSV format (FreeTubeApp#8430)
  Move external player handling to the main process (FreeTubeApp#8416)
  Revert "[Bug fix] Set max-block-size to prevent thin videos from passing the …" (FreeTubeApp#8418)
  Migrate the App component to the composition API (FreeTubeApp#8417)
  Bump electron-builder from 26.3.5 to 26.3.6 (FreeTubeApp#8422)
  Bump css-minimizer-webpack-plugin from 7.0.3 to 7.0.4 (FreeTubeApp#8428)
  Bump the eslint group with 3 updates (FreeTubeApp#8420)
  Bump sass from 1.94.2 to 1.96.0 (FreeTubeApp#8429)
  Bump vue-router from 4.6.3 to 4.6.4 (FreeTubeApp#8425)
  Bump peter-evans/create-pull-request from 7 to 8 (FreeTubeApp#8423)
  Bump mikefarah/yq from 4.49.2 to 4.50.1 (FreeTubeApp#8427)
  Bump lefthook from 2.0.8 to 2.0.11 (FreeTubeApp#8426)
  Bump electron from 39.2.6 to 39.2.7 (FreeTubeApp#8421)
  Bump actions/upload-artifact from 5 to 6 (FreeTubeApp#8424)
  Translated using Weblate (Russian)
  Translated using Weblate (Bulgarian)
  Translated using Weblate (German)
  Translated using Weblate (Indonesian)
  Translated using Weblate (Portuguese (Brazil))
  Translated using Weblate (Japanese)
  ...
Comment thread src/renderer/helpers/api/local.js Outdated
Comment thread src/renderer/helpers/api/local.js Outdated
@absidue absidue removed the PR: stale label Jan 18, 2026
@FreeTubeApp FreeTubeApp deleted a comment from github-actions Bot Jan 18, 2026
@FreeTubeApp FreeTubeApp deleted a comment from github-actions Bot Jan 18, 2026
@FreeTubeApp FreeTubeApp deleted a comment from github-actions Bot Jan 18, 2026
@FreeTubeApp FreeTubeApp deleted a comment from github-actions Bot Jan 18, 2026
@FreeTubeApp FreeTubeApp deleted a comment from github-actions Bot Jan 18, 2026
* development: (55 commits)
  Translated using Weblate (Chinese (Simplified Han script))
  Translated using Weblate (Czech)
  Translated using Weblate (Russian)
  Translated using Weblate (Polish)
  Translated using Weblate (Kurdish (Central))
  Translated using Weblate (French)
  Use GITHUB_TOKEN instead of dedicated PUSH_TOKEN in auto-merge workflow (FreeTubeApp#8541)
  Local API: Implement SABR for VODs (FreeTubeApp#8047)
  Bump package version from 0.23.12 to 0.23.13 (FreeTubeApp#8531)
  Update CodeQL workflow to match the latest template (FreeTubeApp#8533)
  fix: video player playback rate (FreeTubeApp#8407)
  Decipher live DASH manifest URL (FreeTubeApp#8530)
  Add a show all windows button to the tray menu (FreeTubeApp#8494)
  Disable automatically running the flatpak workflow (FreeTubeApp#8507)
  fix using shift on watch page (FreeTubeApp#8491)
  Translated using Weblate (Hebrew)
  Translated using Weblate (Hebrew)
  Fix WAPT link in README (FreeTubeApp#8529)
  Fix typo in auto-merge workflow (FreeTubeApp#8518)
  Added translation using Weblate (Uzbek)
  ...
@PikachuEXE
Copy link
Copy Markdown
Member Author

Updated

@absidue absidue added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 23, 2026
@PikachuEXE
Copy link
Copy Markdown
Member Author

@ChunkyProgrammer

@FreeTubeBot FreeTubeBot merged commit 96d7aaa into FreeTubeApp:development Jan 25, 2026
5 checks passed
@github-actions github-actions Bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants