Skip to content

Some fixes to Cron#1901

Merged
sanason merged 3 commits intoGSA:developfrom
pburkholder:pb/clean-up-cron
Mar 9, 2026
Merged

Some fixes to Cron#1901
sanason merged 3 commits intoGSA:developfrom
pburkholder:pb/clean-up-cron

Conversation

@pburkholder
Copy link
Copy Markdown
Contributor

Trying to address a few problems with this PR:

  1. Running all the tasks in sequence without waiting for them resulting in a big spike in resource consumption, hitting quota, and the failing the last run-tasks
  2. Using --wait apparently uncovers some failures that were masked when we just kicked off the task and hoped for the best
  3. Using set -e would cause the later tasks not to run if there was a failure earlier.

I non-prod I noticed that some of the tasks with --wait are failing.

We don't want failing tasks to kill the entire job. We also don't want to bury failures. So this will keep track of the failues and mark the tasks as failing in CircleCI -- while still running as many as possible.
@pburkholder
Copy link
Copy Markdown
Contributor Author

Meanwhile, I've bumped the quota another 5Gb to allow the current cronjob to complete.

@sanason sanason self-requested a review March 9, 2026 16:02
Copy link
Copy Markdown
Member

@sanason sanason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been months since the Touchpoints cron job ran successfully. Let's give this a try. Thanks, @pburkholder !

@sanason sanason merged commit 803be79 into GSA:develop Mar 9, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants