Conversation
|
/format |
|
I feel the logo definition should be separated into a standalone method, similar to the method to plot the GMT logo. This would allow to plot the PyGMT logo by calling something like |
|
ruff v0.10.0 was released 2 hours ago causing the newly falling code style checks. |
| symbol = "c" # circle | ||
| size_shape = r0 + r1 # radius | ||
| size_shape_add = r0 - r1 | ||
| hex_factor = 1 |
There was a problem hiding this comment.
Instead of defining variables like hex_factor/y_vertline/y_arrow. Can we just define different radii for circle and hexagon shapes?
There was a problem hiding this comment.
Hm, not sure, if this is easy possible. I think the critical point is that for the hexagon shape, the distance to the shape outlines varies, e.g., it is different between the horizontal compass lines and the vertical red line or the arrow for the letter T.
Maybe your are right and we should focus on the circle shape first (and if wanted or requested we can add the hexagon version later).
There was a problem hiding this comment.
The logo will appear in Figure 2, but we don't have to finalize it before the manuscript is accepted. So we still have plenty of time to improve it.
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
This reverts commit 64f6c9a.
Description of proposed changes
Related to #1404 (comment), create the PyGMT logo in Python with PyGMT.
Figure.pygmtlogoorFigure.logo_pygmtas part of theFigureclass or addition to the methodFigure.logo(which plots the GMT logo)Preview:
Related to
TODO:
shape="circle" | "hexagon"orhex=False | TrueFigure.image)Figureclass or addition toFigure.logo.Issues:
Figureobjects using the saved eps files. Maybe this is not easy to handle when converting to a method of theFigureclasse.Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash command is:
/format: automatically format and lint the code