Skip to content

BREAKING: Raise GMTParameterError exception for conflicts_with parameters. Previously raise GMTInvalidInput#4387

Merged
seisman merged 46 commits intoGenericMappingTools:mainfrom
Chuan1937:feature/conflict
Feb 6, 2026
Merged

BREAKING: Raise GMTParameterError exception for conflicts_with parameters. Previously raise GMTInvalidInput#4387
seisman merged 46 commits intoGenericMappingTools:mainfrom
Chuan1937:feature/conflict

Conversation

@Chuan1937
Copy link
Contributor

@Chuan1937 Chuan1937 commented Feb 4, 2026

Add GMTParameterError: conflicts_with

@seisman
This is the fourth PR of #4003

Error types Preferred Parameter Name Alternative Parameter Names Error Message Template
Required required must_have, needed Missing required parameter: '{param}'
Missing required parameters: '{a}', '{b}'
At least one is required at_least_one need_one_of, , , any_of``one_of``required_any Missing required parameters: '{a}', '{b}', '{c}'. Must specify at least one.
Must specify at least one of the parameters: '{a}', '{b}', '{c}'
At most one at_most_one mutually_exclusive Mutually exclusive parameters: '{a}', '{b}', '{c}'. Specify at most one
Conflicting conflicts_with conflicts, incompatible_with Conflicting parameters: '{a}' cannot be used with '{b}', '{c}'

Chuan1937 and others added 4 commits February 4, 2026 17:21
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@Chuan1937 Chuan1937 requested a review from seisman February 4, 2026 09:26
Chuan1937 and others added 3 commits February 4, 2026 17:36
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@seisman seisman added maintenance Boring but important stuff for the core devs final review call This PR requires final review and approval from a second reviewer labels Feb 4, 2026
@seisman seisman added this to the 0.19.0 milestone Feb 4, 2026
@seisman seisman self-requested a review February 4, 2026 09:43
@seisman
Copy link
Member

seisman commented Feb 4, 2026

Please also update pygmt/alias.py.

@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Feb 4, 2026
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@seisman
Copy link
Member

seisman commented Feb 6, 2026

This PR is almost in good shape. The failing tests are actually because set in Python is not order-guaranteed, so using set is likely a bad idea.

Chuan1937 and others added 6 commits February 6, 2026 16:27
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@Chuan1937
Copy link
Contributor Author

This PR is almost in good shape. The failing tests are actually because set in Python is not order-guaranteed, so using set is likely a bad idea.

Indeed, I have been making corrections along the wrong path. Thank you for your corrections.

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Chuan1937 and others added 2 commits February 6, 2026 16:41
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@seisman seisman merged commit c5743fd into GenericMappingTools:main Feb 6, 2026
15 of 20 checks passed
@Chuan1937 Chuan1937 deleted the feature/conflict branch February 6, 2026 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants