Read media durations as natural language for TalkBack#6465
Merged
Conversation
Contributor
Author
|
@CodeRabbit review |
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
✅ Actions performedReview triggered.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
WalkthroughThis pull request adds comprehensive accessibility enhancements by introducing a locale-aware ChangesAccessibility enhancements for audio/video durations
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
SDK Size Comparison 📏
|
gpunto
reviewed
May 27, 2026
ConfigurationCompat.getLocales(...)[0] can return null on a degenerate empty locale list. Crashing the app for a TalkBack content-description is disproportionate; Locale.getDefault() is a graceful fallback that costs nothing and stays correct.
The helper is used in audio, video, media badges, and quoted-message builders. Moving it out of PlaybackTimer.kt into SpokenDuration.kt (same package) makes it easier to locate without changing any call sites.
… off PlaybackTimerText and other playback / recording UIs recomputed the spoken duration on every frame, re-resolving the locale and calling MeasureFormat.getInstance(...) each time. Introduce SpokenDurationFormatter, which selects a strategy once at construction (locale-aware natural language on API 24+, the visible clock format below), and a rememberSpokenDurationFormatter helper that resolves locale once per composition and returns null when no accessibility service is active — call sites then skip setting contentDescription entirely in the common case.
PR #6441 refactored the recording overview content into OverviewPlaybackButton and OverviewPlaybackRow, and put a merged-row contentDescription on the row. During the rebase, the spoken-duration contentDescription that lived on the inline duration Text was dropped along with the inline body. Without it, TalkBack reads the visible "0:00" as "audio recording, zero hundred". Restore the spoken-duration contentDescription on the duration Text so the merged-row announcement becomes "audio recording, 0 seconds" and tracks the visible position while scrubbing.
andremion
force-pushed
the
fix/compose-talkback-media-duration
branch
from
ad66389 to
6efc257
Compare
VelikovPetar
approved these changes
May 27, 2026
gpunto
approved these changes
May 27, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AND-1180
Goal
TalkBack used to read media durations character by character ("zero colon two three"), which is slow and hard to parse. This PR makes durations spoken as natural language ("23 seconds", "1 minute 23 seconds") across every surface that displays a duration in the Compose SDK.
Implementation
spokenDurationhelper inPlaybackTimer.ktproduces a speech-friendly duration string viaMeasureFormat(API 24+), falling back to the existingChatTheme.durationFormatteron older API levels. A non-Composable variant is exposed for call sites that build strings outside Compose (QuotedMessageBodyBuilder).contentDescriptionon every visiblemm:ssTextwhile keeping the displayed text unchanged:PlaybackTimerText)AudioRecordingContent)VideoPlaybackControls)VideoBadgeandAudioBadge(MediaBadges)QuotedMessageBody.spokenTextpopulated byQuotedMessageBodyBuilder, consumed byQuotedMessageText)No visible UI changes; the rendered text and layout are unchanged.
Testing
Summary by CodeRabbit