handle excluded policy breaks

[gg-mmill]

• fix load_default for incident_url (None instead of False)
• Handle two new fields in PolicyBreaks, that will be returned by the scan routes.

A bit bothered by using two fields, but using a single exclude_reason does not seem right either.

[gg-mmill]

We could validate that exclude_reason is not None only when is_excluded is True, but I'm not sure py-gitguardian is the right place for that, WDYT ?

[gg-mmill]

I will also need to make changes to the client, but I'll wait for the feature to be at least available in staging.

[gg-mmill]

I will also need to make changes to the client, but I'll wait for the feature to be at least available in staging.

@agateau-gg added the parameters to the client, should be ready now.

[agateau-gg]

Looks good!

[agateau-gg]

Can you move the new argument at the end? If we don't then we break the API if the function is passed a value for extra_headers without using a keyword argument for it.

Actually it would be a good idea to add a *, after extra_headers so that we don't have this issue with future arguments.

[gg-mmill]

Done

[gg-mmill]

What about multi_content_scan ? Should I make ignore_known_secrets mandatory kwarg ?

[gg-mmill]

Made it like that for now, so as not to introduce breaking changes:

        ignore_known_secrets: Optional[bool] = None,
        *,
        all_secrets: Optional[bool] = None,

[agateau-gg]

Makes sense 👍

[agateau-gg]

Looks good 👍