-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(genai): add live samples (2) #10208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(genai): add live samples (2) #10208
Conversation
|
Here is the summary of changes. You are about to add 6 region tags.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @jdomingr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the Generative AI SDK's live samples, providing developers with practical examples for integrating advanced AI capabilities. The new samples cover a range of interactive scenarios, from real-time audio conversations and text-to-speech generation to complex function calling, grounding with RAG engines, and structured data extraction. These additions aim to enhance understanding and ease of use for various live AI applications. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces several new live samples for the GenAI SDK, covering audio responses, conversation, function calling, grounding, structured output, and text responses from audio. The changes include adding a new dependency for OpenAI client and new Java files for each sample. Overall, the new samples demonstrate various capabilities of the Live API effectively. However, there are several instances of hardcoded values and placeholders that should be made configurable for better reusability and clarity.
genai/snippets/src/main/java/genai/live/LiveStructuredOutputWithTxt.java
Show resolved
Hide resolved
| private static CompletableFuture<Void> sendAudio(AsyncSession session, byte[] audioBytes) { | ||
| return session.sendRealtimeInput( | ||
| LiveSendRealtimeInputParameters.builder() | ||
| .audio(Blob.builder().data(audioBytes).mimeType("audio/pcm;rate=16000").build()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The MIME type and audio rate are hardcoded. These values might vary depending on the audio source. It would be better to derive them from the audioBytes or make them configurable.
.audio(Blob.builder().data(audioBytes).mimeType("audio/pcm;rate=16000").build()) // Consider making mimeType and rate dynamic
Description
Add new live samples
Checklist
mvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only