Vmware: Add nsx_edge_config to google_vmwareengine_private_cloud - #18604
Open
snehaa-chhajed wants to merge 1 commit into
Open
Vmware: Add nsx_edge_config to google_vmwareengine_private_cloud#18604snehaa-chhajed wants to merge 1 commit into
snehaa-chhajed wants to merge 1 commit into
Conversation
This configures NSX Edge cluster attributes (count, ha_mode, size). The network_config was changed to not be immutable as a whole, transferring immutability to management_cidr and vmware_engine_network, to allow in-place updates of the nsx_edge_config block.
modular-magician
added
the
awaiting-approval
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
nsx_edge_configblock to thegoogle_vmwareengine_private_cloudresource for public GA, enabling users to specify the number of edges, HA mode, and size for their Private Cloud.Also transitions
network_configimmutability to its individual child fields to allow in-place updates for edge config mutations.Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.