Skip to content

chore(gae): Remove older region tag #4018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hivanalejandro wants to merge 6 commits into from
+2 −5
Closed

chore(gae): Remove older region tag #4018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
aba58b9
chore(gae): Remove older region tag
hivanalejandro Mar 6, 2025
1d16257
Merge branch 'main' into hivanalejandro-delete-region-401222835
iennae Mar 7, 2025
d18ee6e
Merge branch 'main' into hivanalejandro-delete-region-401222835
hivanalejandro Mar 18, 2025
5fe400f
fix(gae): fix linting issues
hivanalejandro Mar 18, 2025
2e311d9
fix(gae): fix linting issues
hivanalejandro Mar 18, 2025
402614e
Merge branch 'main' into hivanalejandro-delete-region-401222835
hivanalejandro Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions appengine/building-an-app/build/app.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@
# See the License for the specific language governing permissions and
# limitations under the License.

# [START app_yaml]
Copy link
Contributor

@eapl-gemugami eapl-gemugami Mar 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. You are going to have a conflict with the rename in PR chore(gae): Remove older region tag #4032 for file appengine/building-an-app/update/app.yaml.

  2. The fixed region tag requires a language suffix for node

See polls.yaml#L25 as an example, and the internal resource naming-a-new-region-tag

~ ~ ~

You could use gae_build_app_yaml_node.

# [START gae_app_yaml]
runtime: nodejs20
# [END gae_app_yaml]
# [END app_yaml]
5 changes: 2 additions & 3 deletions appengine/building-an-app/build/test/server.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,14 @@ const supertest = require('supertest');
const path = require('path');
const app = require(path.join(__dirname, '../', 'server.js'));


describe('gae_app', () => {
it('should be listening', async () => {
await supertest(app).get('/').expect(200);
});
})
});

describe('gae_build_web_server_app', () => {
it('should be listening', async () => {
await supertest(app).get('/').expect(200);
});
})
});
Loading