-
Notifications
You must be signed in to change notification settings - Fork 1k
fix(deps): update dependency symfony/yaml to v8 #2170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update dependency symfony/yaml to v8 #2170
Conversation
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Renovate bot, upgrades the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request proposes updating the symfony/yaml dependency from ^5.2 to ^8.0. This is a major version upgrade that introduces a new minimum PHP version requirement of ^8.3. The project files, specifically phpunit.xml.dist, suggest that this sample application targets PHP 7.2. This dependency update would therefore be incompatible and would likely break the application. I have added a critical review comment explaining this incompatibility and recommending that the change be rejected.
| "slim/twig-view": "^3.0", | ||
| "php-di/slim-bridge": "^3.1", | ||
| "symfony/yaml": "^5.2" | ||
| "symfony/yaml": "^8.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This update to symfony/yaml:^8.0 requires PHP version ^8.3. However, this project appears to target an older PHP runtime. For instance, the phpunit.xml.dist file references "PHP 7.2" in the test suite name, which is a strong indicator of the target environment.
Upgrading to this version of symfony/yaml will likely cause the application to fail during dependency installation or at runtime due to the incompatible PHP version. It is highly recommended to reject this update to maintain compatibility with the existing environment.
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
This PR contains the following updates:
^5.2->^8.0Release Notes
symfony/yaml (symfony/yaml)
v8.0.0Compare Source
v7.4.0Compare Source
v7.3.5Compare Source
v7.3.3Compare Source
Changelog (symfony/yaml@v7.3.2...v7.3.3)
v7.3.2Compare Source
Changelog (symfony/yaml@v7.3.1...v7.3.2)
v7.3.1Compare Source
Changelog (symfony/yaml@v7.3.0...v7.3.1)
v7.3.0Compare Source
Changelog (symfony/yaml@v7.3.0-RC1...v7.3.0)
v7.2.9Compare Source
Changelog (symfony/yaml@v7.2.8...v7.2.9)
v7.2.8Compare Source
Changelog (symfony/yaml@v7.2.7...v7.2.8)
v7.2.6Compare Source
Changelog (symfony/yaml@v7.2.5...v7.2.6)
v7.2.5Compare Source
Changelog (symfony/yaml@v7.2.4...v7.2.5)
v7.2.3Compare Source
Changelog (symfony/yaml@v7.2.2...v7.2.3)
v7.2.0Compare Source
Changelog (symfony/yaml@v7.2.0-RC1...v7.2.0)
v7.1.11Compare Source
Changelog (symfony/yaml@v7.1.10...v7.1.11)
v7.1.6Compare Source
Changelog (symfony/yaml@v7.1.5...v7.1.6)
v7.1.5Compare Source
Changelog (symfony/yaml@v7.1.4...v7.1.5)
v7.1.4Compare Source
Changelog (symfony/yaml@v7.1.3...v7.1.4)
v7.1.1Compare Source
Changelog (symfony/yaml@v7.1.0...v7.1.1)
v7.1.0Compare Source
Changelog (symfony/yaml@v7.1.0-RC1...v7.1.0)
v7.0.8Compare Source
Changelog (symfony/yaml@v7.0.7...v7.0.8)
v7.0.7Compare Source
Changelog (symfony/yaml@v7.0.6...v7.0.7)
v7.0.3Compare Source
Changelog (symfony/yaml@v7.0.2...v7.0.3)
v7.0.0Compare Source
Changelog (symfony/yaml@v7.0.0-RC2...v7.0.0)
v6.4.26Compare Source
Changelog (symfony/yaml@v6.4.25...v6.4.26)
v6.4.25Compare Source
Changelog (symfony/yaml@v6.4.24...v6.4.25)
v6.4.24Compare Source
Changelog (symfony/yaml@v6.4.23...v6.4.24)
v6.4.23Compare Source
Changelog (symfony/yaml@v6.4.22...v6.4.23)
v6.4.21Compare Source
Changelog (symfony/yaml@v6.4.20...v6.4.21)
v6.4.20Compare Source
Changelog (symfony/yaml@v6.4.19...v6.4.20)
v6.4.18Compare Source
Changelog (symfony/yaml@v6.4.17...v6.4.18)
v6.4.13Compare Source
Changelog (symfony/yaml@v6.4.12...v6.4.13)
v6.4.12Compare Source
Changelog (symfony/yaml@v6.4.11...v6.4.12)
v6.4.11Compare Source
Changelog (symfony/yaml@v6.4.10...v6.4.11)
v6.4.8Compare Source
Changelog (symfony/yaml@v6.4.7...v6.4.8)
v6.4.7Compare Source
Changelog (symfony/yaml@v6.4.6...v6.4.7)
v6.4.3Compare Source
Changelog (symfony/yaml@v6.4.2...v6.4.3)
v6.4.0Compare Source
Changelog (symfony/yaml@v6.4.0-RC2...v6.4.0)
v6.3.12Compare Source
Changelog (symfony/yaml@v6.3.11...v6.3.12)
v6.3.8Compare Source
Changelog (symfony/yaml@v6.3.7...v6.3.8)
v6.3.7Compare Source
Changelog (symfony/yaml@v6.3.6...v6.3.7)
v6.3.3Compare Source
Changelog (symfony/yaml@v6.3.2...v6.3.3)
v6.3.0Compare Source
Changelog (symfony/yaml@v6.3.0-RC2...v6.3.0)
v6.2.10Compare Source
Changelog (symfony/yaml@v6.2.9...v6.2.10)
v6.2.7Compare Source
Changelog (symfony/yaml@v6.2.6...v6.2.7)
v6.2.5Compare Source
Changelog (symfony/yaml@v6.2.4...v6.2.5)
v6.2.2Compare Source
Changelog (symfony/yaml@v6.2.1...v6.2.2)
v6.2.0Compare Source
Changelog (symfony/yaml@v6.2.0-RC2...v6.2.0)
v6.1.11Compare Source
v6.1.9Compare Source
Changelog (symfony/yaml@v6.1.8...v6.1.9)
v6.1.8Compare Source
Changelog (symfony/yaml@v6.1.7...v6.1.8)
v6.1.6Compare Source
Changelog (symfony/yaml@v6.1.5...v6.1.6)
v6.1.4Compare Source
Changelog (symfony/yaml@v6.1.3...v6.1.4)
v6.1.3Compare Source
Changelog (symfony/yaml@v6.1.2...v6.1.3)
v6.1.2Compare Source
Changelog (symfony/yaml@v6.1.1...v6.1.2)
v6.1.0Compare Source
Changelog (symfony/yaml@v6.1.0-RC1...v6.1.0)
v6.0.19Compare Source
Changelog (symfony/yaml@v6.0.18...v6.0.19)
v6.0.17Compare Source
Changelog (symfony/yaml@v6.0.16...v6.0.17)
v6.0.16Compare Source
Changelog (symfony/yaml@v6.0.15...v6.0.16)
v6.0.14Compare Source
Changelog (symfony/yaml@v6.0.13...v6.0.14)
v6.0.12Compare Source
Changelog (symfony/yaml@v6.0.11...v6.0.12)
v6.0.11Compare Source
Changelog (symfony/yaml@v6.0.10...v6.0.11)
v6.0.10Compare Source
Changelog (symfony/yaml@v6.0.9...v6.0.10)
v6.0.3Compare Source
Changelog (symfony/yaml@v6.0.2...v6.0.3)
v6.0.2Compare Source
Changelog (symfony/yaml@v6.0.1...v6.0.2)
v6.0.1Compare Source
Changelog (symfony/yaml@v6.0.0...v6.0.1)
v6.0.0Compare Source
Changelog (symfony/yaml@v6.0.0-RC1...v6.0.0)
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.