Skip to content

Conversation

@Ravikiran-goud
Copy link

Description

This PR addresses @pierrelstan’s feedback on the previous PR for ticket #436 by updating the GitHub Actions workflow (github-ci.yml) to use the correct path apps/web/ instead of web/, fixing the Install dependencies job failure. The on.pull_request section triggers CI only for changes in apps/web/** or .github/workflows/**. The cypress-tests job now runs yarn cy:component as per apps/web/package.json. The build documentation (build-process-treetracker-wallet-app.md) reflects the updated path and script.

Fixes: #436


Changes Made

  • Changes in apps folder:

    • Web: Updated CI to trigger for apps/web/ changes, with working-directory: apps/web and yarn cy:component for tests.
    • Native: No changes.
  • Changes in packages folder:

    • Core: No changes.
  • Other changes:

    • Updated .github/workflows/github-ci.yml with paths: ['apps/web/**', '.github/workflows/**'] and working-directory: apps/web.
    • Set Cypress command to yarn cy:component.
    • Updated build-process-treetracker-wallet-app.md for apps/web/ and cy:component.

Type of Change

  • 🐛 Bug fix (fixed incorrect web/ path and Cypress script)
  • 📝 Documentation update (changes to build-process-treetracker-wallet-app.md)

Screenshots

Before After
CI failed on web/ path CI triggers for apps/web/

No visual screenshots as changes are in CI and documentation.


How Has This Been Tested?

  • Cypress component tests: Ran yarn install && yarn cy:component in apps/web/ locally to verify test execution.
  • Cypress integration: Not applicable.
  • Jest unit tests: Not applicable.
  • Additional testing:
    • Validated github-ci.yml syntax with yamllint.
    • Tested locally with act to simulate PR workflow.
    • Created test PRs with apps/web/dummy.txt (CI triggers) and apps/native/ (CI skips).
    • This PR should trigger CI due to .github/workflows/ changes.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas (comments in github-ci.yml)
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (existing Cypress tests sufficient)
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules (none affected)

Additional Comments

  • Addressed @pierrelstan’s feedback by using apps/web/ and yarn cy:component.
  • Notified @emmanuel - Cloud Lead via email with PR link.
  • Recommend testing a non-apps/web/ PR post-merge to confirm CI skip.
  • Open to further adjustments if a different Cypress script is required.

@Ravikiran-goud Ravikiran-goud requested a review from a team as a code owner June 21, 2025 01:59
@dadiorchen
Copy link
Collaborator

@pierrelstan can you review this?

Copy link
Collaborator

@pierrelstan pierrelstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Ravikiran-goud ,thanks for your PR! Would you mind squashing your commits into a single one for a cleaner Git history? Feel free to reach out if you have any questions. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants