Skip to content

Conversation

@EmmaLi1
Copy link
Contributor

@EmmaLi1 EmmaLi1 commented Oct 7, 2025

Description

This PR implements a user information modal that displays wallet creation limits, improving user experience by providing clear guidance on system constraints.

Fixes: #363


Changes Made

  • Changes in apps folder (specify the app and briefly describe the changes):

    • Web
    • Native
      • Added LimitInfoModal component to display wallet limit information
      • Updated wallet screen to include info icon next to CREATE WALLET button
      • Integrated modal with tap-to-dismiss functionality
  • Changes in packages folder (specify the package and briefly describe the changes):

    • Core

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 Documentation update (changes)

Screenshots

Before After
Before - No info icon After - Info icon and modal

How Has This Been Tested?

  • Cypress integration
  • Cypress component tests
  • Jest unit tests
    • Modal visibility tests
    • User interaction tests (open/close)
    • Content display verification

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@EmmaLi1 EmmaLi1 mentioned this pull request Oct 7, 2025
Comment on lines 41 to 47
<TouchableOpacity
style={styles.createWalletButton}
onPress={handleCreateWallet}
activeOpacity={0.7}>
<Ionicons name="add" size={24} color="#999999" />
<Text style={styles.createWalletText}>CREATE WALLET</Text>

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the create wallet button

walletLimit = 2,
}) => {
return (
<Modal
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reuse existing CustomModal for consistency

@EmmaLi1 EmmaLi1 requested a review from pierrelstan October 20, 2025 05:04
Copy link
Collaborator

@pierrelstan pierrelstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EmmaLi1 Looks like this PR has some merge conflicts. Could you fix them?

@EmmaLi1 EmmaLi1 requested a review from pierrelstan October 30, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Limit info component

2 participants