Skip to content

Conversation

@calmcat2
Copy link
Member

@calmcat2 calmcat2 commented Dec 4, 2025

Description

Following the README.md, this workflow triggers on pull requests that modify files (other than *.md) in the wallet package (i.e., package/wallet/**)
It runs e2e tests to validate changes.

Resolves: #579


Changes Made

  • Changes in apps folder (specify the app and briefly describe the
    changes):

    • Web
    • Native
    • None
  • Changes in packages folder (specify the package and briefly describe
    the changes):

    • Core
    • None

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing
    functionality to not work as expected)
  • 📝 Documentation update (changes)

Screenshots

The workflow has been verified in a forked repo
image


How Has This Been Tested?

  • Cypress integration
  • Cypress component tests
  • Jest unit tests

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional Comments

Environment variables and secrets required by this workflow are already configured in the upstream repository.

Copy link
Collaborator

@dadiorchen dadiorchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@dadiorchen
Copy link
Collaborator

@calmcat2 is this ready for merge?

@calmcat2
Copy link
Member Author

calmcat2 commented Dec 8, 2025

Thanks to Stanley's feedback, I've made the following improvements to the workflow:

  1. Removed the section for starting up web and user services since the Jest tests don’t require the frontend or backend to be running.
  2. Ran yarn test from the repository root instead of packages/wallet.
  3. Fixed some typos.
    @dadiorchen It it looks good to you, it's ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PR CI/CD for wallet package

2 participants