Closed
Conversation
…emented due to confusing build fail)
krossgg
reviewed
Dec 28, 2025
Contributor
krossgg
left a comment
There was a problem hiding this comment.
Personally, I don't like having these wood compats in the base mod. It's kinda more dependency + lines of code bloat. @Ghostipedia can chime in with their thoughts.
Arguably, the right thing to do is to make the entries list mutable (which you've done) and to fire an event (both modbus and kjs) that lets people add to the entries list with their own WoodTypeEntry after the defaults are added.
n.b. if you plan on implementing my suggestion, the same thing should be done for StoneTypeEntry as well.
| } | ||
|
|
||
| private static List<WoodTypeEntry> DEFAULT_ENTRIES; | ||
| private static ArrayList<WoodTypeEntry> DEFAULT_ENTRIES; |
Contributor
There was a problem hiding this comment.
This should stay as List, it is generally better to keep declared types as generics for polymorphism.
| private static ArrayList<WoodTypeEntry> DEFAULT_ENTRIES; | ||
|
|
||
| private static List<WoodTypeEntry> getDefaultEntries() { | ||
| private static ArrayList<WoodTypeEntry> getDefaultEntries() { |
Co-authored-by: kross <135918757+krossgg@users.noreply.github.com>
…be instantiated" and make stone mutable similar to wood
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Allows modders and pack makers to add their own WoodTypeEntry or StoneTypeEntry to append to getDefaultEntries() in WoodMachineRecipes and StoneMachineRecipes
(in progress - modifying previous changes)
Old PR:
What
Adds the option to include items from other mods in recipe changes for consistency. Currently:
(New PR because github was being weird thinking I changed 4k lines. Formatting should also be fixed since old PR)
Implementation Details
Changed getDefaultEntries() in WoodMachineRecipes.java to use an ArrayList rather than an Array to allow for adding wood sets without calculating how many would need to be added first.
Each mod's recipes can be toggled by a new setting in config > compat > recipes (the recipes section is also new specifically for this).
The recipes will only be loaded if both the config option for the mod and the respective option for the feature in config > recipes are enabled.
Each mod's recipes are in their own file, and the methods in each class are only called if the mod is loaded, so Gregtech does not crash due to missing packages if the mods are not installed.
The wood recipes follow the exact same pattern as the existing vanilla wood recipe changes, since the wood types are registered the same way.
The redstone recipes follow as similar a pattern as possible to existing changes.
Additional Information
Here are some screenshots of the recipes working:




Potential Compatibility Issues
If GTCEu resources are loaded before the other mods, the recipes may not get removed if they are changed. This can be fixed by removing Gregtech, launching Minecraft (and possibly loading the world), and then going into the world with Gregtech installed again.
Create duplicate recipe (The world was loaded without Create first, then Create was added, so Create resources were placed above Gregtech resources):
