Open
Conversation
Member
|
Ooh, this looks really nice. I'll try to review it tomorrow or Sunday |
PaintNinja
reviewed
Apr 15, 2023
PaintNinja
reviewed
Apr 15, 2023
| group = 'no' | ||
|
|
||
| requires ItemTags.COAL_ORES | ||
| }.save() |
Member
There was a problem hiding this comment.
Are there any scenarios where you wouldn't want to save this immediately? If not, this could be auto-saved.
Member
Author
There was a problem hiding this comment.
Saving forgotten recipes is already handled by saveForgotten().
Member
There was a problem hiding this comment.
But are there any cases where you would want to define recipes and not save them? If not, auto-save by default would be more user-friendly.
PaintNinja
reviewed
Apr 15, 2023
PaintNinja
reviewed
Apr 15, 2023
Common/src/main/groovy/io/github/groovymc/cgl/api/datagen/recipe/GShapedRecipeBuilder.groovy
Show resolved
Hide resolved
PaintNinja
reviewed
Apr 15, 2023
Common/src/main/groovy/io/github/groovymc/cgl/api/datagen/recipe/GRecipeProvider.groovy
Outdated
Show resolved
Hide resolved
lukebemish
reviewed
Apr 15, 2023
Common/src/extension/groovy/io/github/groovymc/cgl/api/extension/ItemExtensions.groovy
Show resolved
Hide resolved
Common/src/extension/groovy/io/github/groovymc/cgl/api/extension/ItemExtensions.groovy
Show resolved
Hide resolved
Common/src/extension/groovy/io/github/groovymc/cgl/api/extension/ItemExtensions.groovy
Outdated
Show resolved
Hide resolved
Common/src/main/groovy/io/github/groovymc/cgl/api/datagen/recipe/GRecipeProvider.groovy
Outdated
Show resolved
Hide resolved
Common/src/main/groovy/io/github/groovymc/cgl/api/datagen/recipe/GRecipeProvider.groovy
Outdated
Show resolved
Hide resolved
Common/src/main/groovy/io/github/groovymc/cgl/api/datagen/recipe/GShapedRecipeBuilder.groovy
Show resolved
Hide resolved
Common/src/main/groovy/io/github/groovymc/cgl/api/datagen/recipe/GShapedRecipeBuilder.groovy
Show resolved
Hide resolved
Common/src/main/groovy/io/github/groovymc/cgl/api/datagen/recipe/GShapedRecipeBuilder.groovy
Outdated
Show resolved
Hide resolved
...on/src/main/groovy/io/github/groovymc/cgl/api/datagen/recipe/GSingleItemRecipeBuilder.groovy
Outdated
Show resolved
Hide resolved
lukebemish
approved these changes
Jun 25, 2023
Member
lukebemish
left a comment
lukebemish
left a comment
There was a problem hiding this comment.
Looks good to me, though I haven't tested it
PaintNinja
requested changes
Jun 26, 2023
Member
PaintNinja
left a comment
PaintNinja
left a comment
There was a problem hiding this comment.
Marking a conversation as resolved when asked a question doesn't answer it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a datagen API for recipes only, currently.