Skip to content

🧪 test: add missing error handling tests for handleExport#258

Draft
max-ostapenko wants to merge 1 commit intomainfrom
test-handle-export-errors-14130636018337806580
Draft

🧪 test: add missing error handling tests for handleExport#258
max-ostapenko wants to merge 1 commit intomainfrom
test-handle-export-errors-14130636018337806580

Conversation

@max-ostapenko
Copy link
Contributor

🎯 What: The testing gap addressed was missing tests for the catch block and general error handling within handleExport of infra/dataform-service/src/index.js.

📊 Coverage: Covered normal failure scenarios such as missing payloads, bad payload properties, unsupported destinations, and an injected error testing when callRunJob fails via Node's testing mock framework.

Result: Enhanced the resilience of the BigQuery exporting job logic through deterministic CI-compatible error validation tests without needing complex dependency injection refactors.


PR created automatically by Jules for task 14130636018337806580 started by @max-ostapenko

- Refactored index.js in dataform-service to export internals for mocking
- Created index.test.js with test cases for expected behaviors, focusing on catching simulated errors in the job queue and various request payload malformations.
- Updated package.json in dataform-service with `node --test` script.
@google-labs-jules
Copy link

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant