fix: FIT-1412: In Interactive task source, Search returns no results when certain filters (All, Annotations, Predictions, Data) are applied#9440
Closed
yyassi-heartex wants to merge 1 commit intolse-release/2.33.0from
Conversation
…when certain filters (All, Annotations, Predictions, Data) are applied (#9435) Co-authored-by: yyassi-heartex <yyassi-heartex@users.noreply.github.com>
ricardoantoniocm
approved these changes
Feb 19, 2026
nass600
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds comprehensive tests for the
JsonViewercomponent's filtered search functionality and improves the search logic to provide more robust fallback matching. The main focus is to ensure that searching within the JSON viewer works as expected, even when custom filters are applied or when the default search logic does not match.Testing improvements:
json-viewer.test.tsxthat verifies the search functionality ofJsonViewer, including scenarios with custom filters and explicit filter selection.Search logic enhancements:
fallbackNodeMatchfunction injson-viewer.tsxto provide additional matching logic when the defaultmatchNodedoes not find a match. This function checks the node's key, path, and value for the search term.searchFilterlogic inJsonViewerto usefallbackNodeMatchas a backup whenmatchNodereturns false, improving the reliability of search results.