Skip to content

fix: FIT-1412: In Interactive task source, Search returns no results when certain filters (All, Annotations, Predictions, Data) are applied#9440

Closed
yyassi-heartex wants to merge 1 commit intolse-release/2.33.0from
fb-fit-1412/2.33.0
Closed

fix: FIT-1412: In Interactive task source, Search returns no results when certain filters (All, Annotations, Predictions, Data) are applied#9440
yyassi-heartex wants to merge 1 commit intolse-release/2.33.0from
fb-fit-1412/2.33.0

Conversation

@yyassi-heartex
Copy link
Copy Markdown
Contributor

This pull request adds comprehensive tests for the JsonViewer component's filtered search functionality and improves the search logic to provide more robust fallback matching. The main focus is to ensure that searching within the JSON viewer works as expected, even when custom filters are applied or when the default search logic does not match.

Testing improvements:

  • Added a new test suite in json-viewer.test.tsx that verifies the search functionality of JsonViewer, including scenarios with custom filters and explicit filter selection.

Search logic enhancements:

  • Introduced a fallbackNodeMatch function in json-viewer.tsx to provide additional matching logic when the default matchNode does not find a match. This function checks the node's key, path, and value for the search term.
  • Updated the searchFilter logic in JsonViewer to use fallbackNodeMatch as a backup when matchNode returns false, improving the reliability of search results.

…when certain filters (All, Annotations, Predictions, Data) are applied (#9435)

Co-authored-by: yyassi-heartex <yyassi-heartex@users.noreply.github.com>
@github-actions github-actions bot added the fix label Feb 19, 2026
@yyassi-heartex yyassi-heartex requested review from a team and ricardoantoniocm February 19, 2026 22:58
@farioas farioas closed this Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants