Skip to content

[FEATURE] UI: deprecate Modal\RoundTrip and Interruptive #11860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thibsy wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

[FEATURE] UI: deprecate Modal\RoundTrip and Interruptive #11860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions components/ILIAS/UI/src/Component/Modal/Factory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ interface Factory
* @param string $message A plain string informing the user about the critical situation
* @param string $form_action The URL where the modal posts its form data
* @return \ILIAS\UI\Component\Modal\Interruptive
*
* @deprecated use {@see \ILIAS\UI\Component\Prompt\Prompt} instead
*/
public function interruptive(string $title, string $message, string $form_action): Interruptive;

Expand All @@ -93,6 +95,8 @@ public function interruptive(string $title, string $message, string $form_action
* An interruptive item MUST have an ID.
* ---
* @return \ILIAS\UI\Component\Modal\InterruptiveItem\Factory
*
* @deprecated use {@see \ILIAS\UI\Component\Prompt\State\Factory} instead
*/
public function interruptiveItem(): InterruptiveItem\Factory;

Expand Down Expand Up @@ -148,6 +152,8 @@ public function interruptiveItem(): InterruptiveItem\Factory;
* @param Component\Input\Container\Form\FormInput[] $inputs
* @param string|null $post_url
* @return \ILIAS\UI\Component\Modal\RoundTrip
*
* @deprecated use {@see \ILIAS\UI\Component\Prompt\Prompt} instead
*/
public function roundtrip(string $title, Component\Component|array|null $content, array $inputs = [], ?string $post_url = null): RoundTrip;

Expand Down
2 changes: 1 addition & 1 deletion components/ILIAS/UI/src/Component/Modal/Interruptive.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
/**
* Interface Interruptive
*
* @package ILIAS\UI\Component\Modal
* @deprecated use {@see \ILIAS\UI\Component\Prompt\Prompt} instead
*/
interface Interruptive extends Modal
{
Expand Down
6 changes: 5 additions & 1 deletion components/ILIAS/UI/src/Component/Modal/InterruptiveItem/Factory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
/**
* Interface Factory
*
* @package ILIAS\UI\Component\Modal
* @deprecated use {@see \ILIAS\UI\Component\Prompt\State\Factory} instead
*/
interface Factory
{
Expand Down Expand Up @@ -56,6 +56,8 @@ interface Factory
* @param Image $icon
* @param string $description
* @return \ILIAS\UI\Component\Modal\InterruptiveItem\Standard
*
* @deprecated use {@see \ILIAS\UI\Component\Prompt\State\State} instead
*/
public function standard(
string $id,
Expand Down Expand Up @@ -93,6 +95,8 @@ public function standard(
* @param string $key
* @param string $value
* @return \ILIAS\UI\Component\Modal\InterruptiveItem\KeyValue
*
* @deprecated use {@see \ILIAS\UI\Component\Prompt\State\State} instead
*/
public function keyValue(
string $id,
Expand Down
2 changes: 2 additions & 0 deletions components/ILIAS/UI/src/Component/Modal/InterruptiveItem/InterruptiveItem.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
* Interface InterruptiveItem
*
* Represents an item to be displayed inside an interruptive modal
*
* @deprecated use {@see \ILIAS\UI\Component\Prompt\State\State} instead
*/
interface InterruptiveItem extends Component
{
Expand Down
2 changes: 2 additions & 0 deletions components/ILIAS/UI/src/Component/Modal/InterruptiveItem/KeyValue.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@
* Interface InterruptiveItem
*
* Represents a key-value item to be displayed inside an interruptive modal
*
* @deprecated use {@see \ILIAS\UI\Component\Prompt\State\State} instead
*/
interface KeyValue extends InterruptiveItem
{
Expand Down
2 changes: 2 additions & 0 deletions components/ILIAS/UI/src/Component/Modal/InterruptiveItem/Standard.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
* Interface InterruptiveItem
*
* Represents an object to be displayed inside an interruptive modal
*
* @deprecated use {@see \ILIAS\UI\Component\Prompt\State\State} instead
*/
interface Standard extends InterruptiveItem
{
Expand Down
2 changes: 1 addition & 1 deletion components/ILIAS/UI/src/Component/Modal/RoundTrip.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
use ILIAS\UI\Component\Input\Container\Form\Standard;

/**
* @package ILIAS\UI\Component\Modal
* @deprecated use {@see \ILIAS\UI\Component\Prompt\Prompt} instead
*/
interface RoundTrip extends Modal, Standard
{
Expand Down
Loading