-
Notifications
You must be signed in to change notification settings - Fork 22
IDEX Update event time calculation #2664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
IDEX Update event time calculation #2664
Conversation
tech3371
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had one minor question to IDEX team but what you had is good.
p.s. yes, I remember that discussion and I thought I was way off based on response I got. I should have push back more :)
greglucas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I think this is slightly confusing with fine first then two coarse counters. Rather than changing the calculate event time, can you just update the one spot of input to combine the two coarse ints into a single int that you pass into the function, rather than reworking the function itself?
Change Summary
Overview
The IDEX team realized they were using shcoarse for event time calculation. This was actually the time of the packet calculation and not the time when IDEX triggered.
I think @tech3371 you had this concern in the science team meeting a long time ago but I thought they said we were doing it right! Anyway this is the correct way to do it.
Updated Files
-imap_processing/idex/idex_l1a.py