Remove const qualifiers for class/struct members per C++ guidelines#1975
Merged
ndgrigorian merged 1 commit intomasterfrom Jan 21, 2025
Merged
Conversation
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_486 ran successfully. |
Collaborator
ndgrigorian
approved these changes
Jan 20, 2025
Collaborator
ndgrigorian
left a comment
There was a problem hiding this comment.
LGTM! Honestly it's fewer than expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further remove
constqualifier from struct/class members per C++ guidelines.The test should be that each such class instance be device copyable. Perhaps static asserts to this effect can be added to the code.