Merged
Conversation
asarray now treats usm_ndarray the same as numpy arrays when the dtype of the array is not supported by targeted device
ndgrigorian
requested review from
antonwolfy,
vlad-perevezentsev and
vtavana
as code owners
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
antonwolfy
previously approved these changes
Jun 5, 2025
Collaborator
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
In overall, LGTM
Thank you @ndgrigorian
|
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_4 ran successfully. |
Collaborator
ndgrigorian
force-pushed
the
resolve-gh-1046
branch
from
cf27c6a to
9544e89
Compare
antonwolfy
reviewed
Jun 5, 2025
|
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_5 ran successfully. |
|
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_5 ran successfully. |
|
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_6 ran successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-1046
This PR resolves
dpt.asarray(x, device=dev)failing for some arrayxwith dtype not supported by devicedev