-
Notifications
You must be signed in to change notification settings - Fork 23
Deprecate dpnp.fix()
#2730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Deprecate dpnp.fix()
#2730
Conversation
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2730/index.html |
|
Array API standard conformance tests for dpnp=0.20.0dev1=py313h509198e_63 ran successfully. |
antonwolfy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @vlad-perevezentsev
LGTM with a small nit below
| Warning | ||
| ------- | ||
| This function is deprecated. It is recommended to use | ||
| :obj:`dpnp.trunc` instead, as it provides the same functionality of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to use :func: for a reference on a function in the notes. It will be rendered as dpnp.trunc() then.
| :obj:`dpnp.trunc` instead, as it provides the same functionality of | |
| :func:`dpnp.trunc` instead, as it provides the same functionality of |
This PR deprecates
dpnp.fix()in favor ofdpnp.trunc(following NumPy 2.5)It adds
DPNPDeprecatedUnaryFuncwrapper and updates tests to ignore DeprecationWarning