Suppress DPC++/SYCL header deprecation warnings when building dpnp.tensor on Windows#2984
Open
antonwolfy wants to merge 2 commits into
Open
Conversation
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2984/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev2=py313h509198e_9 ran successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #2856 and #2770. The
dpnp.tensortarget never got the sameSYSTEMtreatment, so it was the one target still leaking these warnings.The Windows conda build produced a flood of
-Wdeprecated-declarationswarnings (hundreds of thousands of lines in the CI log). All of them originate inside the DPC++/SYCL headers themselves (.../Library/include/sycl/...) — none come from dpnp's own sources — so they are out of dpnp's control and are pure noise. They came exclusively from thedpnp.tensor_tensor_*_implpybind11 modules built indpnp/tensor/CMakeLists.txt.In the
dpnp/tensortarget loop, split the include directories so dpnp's own headers stayPRIVATE, and the third-party headers (SYCL_INCLUDE_DIR,Dpctl_INCLUDE_DIR, generated Cython headers) are added asSYSTEM PRIVATE, mirroring the pattern established in #2770 for thebackend/extensions/*targets.