Skip to content

Suppress DPC++/SYCL header deprecation warnings when building dpnp.tensor on Windows#2984

Open
antonwolfy wants to merge 2 commits into
pin-conda-to-avoid-installing-faulty-buildfrom
mark-sycl-includes-as-system-for-tensor
Open

Suppress DPC++/SYCL header deprecation warnings when building dpnp.tensor on Windows#2984
antonwolfy wants to merge 2 commits into
pin-conda-to-avoid-installing-faulty-buildfrom
mark-sycl-includes-as-system-for-tensor

Conversation

@antonwolfy

@antonwolfy antonwolfy commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

This PR is a follow-up to #2856 and #2770. The dpnp.tensor target never got the same SYSTEM treatment, so it was the one target still leaking these warnings.

The Windows conda build produced a flood of -Wdeprecated-declarations warnings (hundreds of thousands of lines in the CI log). All of them originate inside the DPC++/SYCL headers themselves (.../Library/include/sycl/...) — none come from dpnp's own sources — so they are out of dpnp's control and are pure noise. They came exclusively from the dpnp.tensor _tensor_*_impl pybind11 modules built in dpnp/tensor/CMakeLists.txt.

In the dpnp/tensor target loop, split the include directories so dpnp's own headers stay PRIVATE, and the third-party headers (SYCL_INCLUDE_DIR, Dpctl_INCLUDE_DIR, generated Cython headers) are added as SYSTEM PRIVATE, mirroring the pattern established in #2770 for the backend/extensions/* targets.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy added this to the 0.21.0 release milestone Jul 1, 2026
@antonwolfy antonwolfy self-assigned this Jul 1, 2026
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/2984/index.html

@antonwolfy antonwolfy marked this pull request as ready for review July 1, 2026 15:27
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Array API standard conformance tests for dpnp=0.21.0dev2=py313h509198e_9 ran successfully.
Passed: 1369
Failed: 4
Skipped: 7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant