Skip to content

Conversation

@lposen
Copy link
Contributor

@lposen lposen commented Jan 23, 2026

🔹 JIRA Ticket(s) if any

✏️ Description

Make the return for getEmbeddedMessages consistent when no apis are given

Test

  • Run android app
  • Log in
  • Click on 'Embedded' tab
  • Without putting any placement ids in, click "Get messages for placement ids" -- All embedded messages should be returned
  • Add a placement id
  • Click "Get messages for placement ids" -- Only embedded messages for that placement id should be returned

@qltysh
Copy link

qltysh bot commented Jan 23, 2026

1 new issue

Tool Category Rule Count
qlty Structure Function with high complexity (count = 14): getEmbeddedMessages 1

@github-actions
Copy link

Lines Statements Branches Functions
Coverage: 63%
63.07% (398/631) 40.07% (103/257) 61.5% (139/226)

@qltysh
Copy link

qltysh bot commented Jan 23, 2026

Qlty

Coverage Impact

Unable to calculate total coverage change because base branch coverage was not found.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants