[SDK-366] parse-styles-for-components#817
Conversation
|
Coverage Impact Unable to calculate total coverage change because base branch coverage was not found. Modified Files with Diff Coverage (4)
🛟 Help
|
…ed component styles
…g unused properties
…ibility in Embedded component
sumeruchat
left a comment
There was a problem hiding this comment.
Good work on the style-parsing system — clean separation of concerns, solid test coverage on getStyles, and the config override pattern using ?? is correct. A few items to address before merge, most notably the debug output left in the production component.
| </Text> | ||
| <Text> | ||
| parsedStyles.bodyTextColor: {String(parsedStyles.bodyTextColor)} | ||
| </Text> |
There was a problem hiding this comment.
Blocker: This entire debug block (lines 51-81) renders raw style values as <Text> nodes on screen, and wraps <Cmp> in an extra <View>. This looks like scaffolding/dev output and should be removed before merge.
There was a problem hiding this comment.
This is just for demonstration and easy testing purposes. It will be removed in future PRs.
| <Text> | ||
| parsedStyles.bodyTextColor: {String(parsedStyles.bodyTextColor)} | ||
| </Text> | ||
| <Cmp {...props} /> |
There was a problem hiding this comment.
parsedStyles is computed but never passed to <Cmp>. The child components (Banner/Card/Notification) won't receive or apply these styles. Should this be something like <Cmp {...props} parsedStyles={parsedStyles} />?
There was a problem hiding this comment.
The whole function is going to go inside the other components in future PRs. This is just for making it easy to test.
| banner: '#F5F4F4', | ||
| }; | ||
|
|
||
| export const embeddedStyles = { |
There was a problem hiding this comment.
embeddedMediaImageBorderColors and embeddedMediaImageBackgroundColors are defined and added to embeddedStyles, but never consumed in getStyles.ts. Remove them or add the corresponding style resolution to avoid dead code.
There was a problem hiding this comment.
You're 100% correct. Good eye. They ended up in here because I was breaking down a very large PR. I'll remove them and add them back in later when they are needed.
joaodordio
left a comment
There was a problem hiding this comment.
+1 on the comments Sumeru already added, other than that looks good!
franco-zalamena-iterable
left a comment
There was a problem hiding this comment.
This is a really technical implementation and I lack the needed knowledge to give helpful insights for React Native. I tested the app with this branch and everything seems to be working.

🔹 JIRA Ticket(s) if any
✏️ Description
Parses styles according for each component type, with the ability to override them externally
Test
{"backgroundColor":"blue"}Screen.Recording.2026-02-23.at.5.02.20.PM.mov