📐 added: OrthogonalCollocation with gaussradau and gausslegendre schemes#322
Open
franckgaga wants to merge 43 commits intomainfrom
Open
📐 added: OrthogonalCollocation with gaussradau and gausslegendre schemes#322franckgaga wants to merge 43 commits intomainfrom
OrthogonalCollocation with gaussradau and gausslegendre schemes#322franckgaga wants to merge 43 commits intomainfrom
Conversation
`nc` was the number of collocation points. I renamed it to `np` since there is confusion with `mpc.con.nc`, the number of custom inequality constraints
The subscript p is already used for `Hp` i.e. "prediction".
A dispatch was not necessary for this.
It's not necessary to differentiate with a `k` vector that would include the operating point (there is never operating point in this vector). And it now follows the nomenclature of `OrthogonalCollocation`
The mutated argument is used to store the result of `model.f!` function, thus it is a derivative of the state. The distinction is more important for code readability of `CollocationMethods`.
The default of 3 collocation points (the internal points, thus it exclude the τ=0 point) is the most common default (e.g. do-mpc, CasADi, etc.)
`o` is misleading with the `λ_o` variable
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #322 +/- ##
==========================================
- Coverage 98.42% 96.54% -1.88%
==========================================
Files 29 29
Lines 5397 5501 +104
==========================================
- Hits 5312 5311 -1
- Misses 85 190 +105 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Hello @baggepinnen, I still need to implement the tests, but do you have any comments on my points above and the documentation of the new Thanks for your time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The transcription method is efficient for highly stiff nonlinear systems. The default
gaussradauquadrature is slightly less accurate thangausslegendre, but its an L-stable method, while the latter being A-stable.Some comments:
SimpleColloc.jl).OrthogonalCollocation, the associatedcon_nonlinprogeq!method andinit_orthocolloc.SimpleColloc.jl), since it's simpler and I'm not convince that it's necessary.Closes #238