Declare whole interface as as public#49
Open
frankier wants to merge 1 commit intoJuliaDatabases:masterfrom
Open
Declare whole interface as as public#49frankier wants to merge 1 commit intoJuliaDatabases:masterfrom
frankier wants to merge 1 commit intoJuliaDatabases:masterfrom
Conversation
Author
|
@spaette Cheeky ping. Hopefully this is an uncontroversial change/easy merge. Let me know if I can add any assurance. |
Contributor
|
Perhaps feedback could be solicited on the subject matter from the above online discussion venue for Julia. |
Author
|
Thanks for the information. It is quite a small change so I'll ping @quinnj first, but if there is some problem, I can take it to Discourse if they agree it would be useful. |
Contributor
|
Would you consider the subject matter of the PR having implications beyond the scope of a single Julia package? |
oxinabox
approved these changes
Apr 4, 2025
Contributor
|
Time permitting would you provide a second review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is already useful in practice with e.g. https://github.com/ericphanson/ExplicitImports.jl which will give false positives for using private implementation at the moment.