implement an antimeridian cutting fix ported from the python package#282
Closed
asinghvi17 wants to merge 7 commits intographite-base/282from
Closed
implement an antimeridian cutting fix ported from the python package#282asinghvi17 wants to merge 7 commits intographite-base/282from
asinghvi17 wants to merge 7 commits intographite-base/282from
Conversation
This was referenced Mar 18, 2025
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
enables geoms .|> fix since fix doesnt have apply integrated(!) we should fix
this is worse for performance, better for predictability and correctness (the most complex trait will be chosen for the application rather than the least complex)
Member
Author
|
Looks like the issue here is that A nice API is |
This was referenced Apr 16, 2025
Merged
Member
Author
|
I guess we no longer need this for the immediate moment and there are no merge conflicts but the implementation is weird |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement an antimeridian cutting fix ported from the python package. This is an interesting fix, since it doesn't fit in the top down framework of fixes so far. It needs special handling for e.g. multipolygons in place of polygons, and multilinestrings in place of linestrings. But we don't have that mechanism at all in fix, so it probably needs to be added at some point...
Fix #218