Skip to content

drop support for Julia <v1.6#91

Open
jishnub wants to merge 3 commits into
JuliaLinearAlgebra:masterfrom
jishnub:julia1.6
Open

drop support for Julia <v1.6#91
jishnub wants to merge 3 commits into
JuliaLinearAlgebra:masterfrom
jishnub:julia1.6

Conversation

@jishnub

@jishnub jishnub commented May 30, 2023

Copy link
Copy Markdown
Member

It's unlikely that users of Julia v1.0 would want the latest versions of packages, so it makes sense to restrict further development to v1.6. In any case, this is meant to be merged along with the next breaking release, so that v0.8 may still receive backported changes, if necessary.

@jishnub jishnub marked this pull request as draft May 30, 2023 07:31
@codecov

codecov Bot commented May 30, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.87%. Comparing base (49bde1d) to head (c7051c8).
⚠️ Report is 36 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
- Coverage   94.98%   94.87%   -0.12%     
==========================================
  Files           7        7              
  Lines         798      819      +21     
==========================================
+ Hits          758      777      +19     
- Misses         40       42       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jishnub jishnub marked this pull request as ready for review June 9, 2023 14:25
@jishnub

jishnub commented Jun 9, 2023

Copy link
Copy Markdown
Member Author

On second thoughts, this isn't a breaking change, and someone who is using julia 1.0 is probably more concerned about stability rather than the latest versions of packages. I would suggest merging this, and moving on.

@dlfivefifty

Copy link
Copy Markdown
Member

The convention is that dropping old versions of Julia is a breaking change

@jishnub

jishnub commented Jun 16, 2023

Copy link
Copy Markdown
Member Author

It appears that colprac doesn't consider dropping support for older Julia versions as a breaking change, although it's a bit blurry for pre-1.0 packages. One needs to decide whether changes will be backported to v1.0, which I doubt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants