Skip to content

Fix typo frragment -> fragment #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
csilvers merged 1 commit into from
May 17, 2025
Merged

Fix typo frragment -> fragment #380

csilvers merged 1 commit into from
May 17, 2025

Conversation

@bryanwweber
Copy link
Contributor

@bryanwweber bryanwweber commented May 17, 2025 •
edited
Loading

I have:

  • Written a clear PR title and description (above)
  • Signed the Khan Academy CLA
  • Added tests covering my changes, if applicable
  • Included a link to the issue fixed, if applicable
  • Included documentation, for new features
  • Added an entry to the changelog

bryanwweber
bryanwweber commented May 17, 2025
View reviewed changes
Copy link
Contributor Author

@bryanwweber bryanwweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This replaces #379, sorry again for the noise!

@csilvers
Copy link
Member

csilvers commented May 17, 2025

Normally I'd wait for @benjaminjkraft to weigh in, but I feel comfortable accepting this one!

@csilvers csilvers merged commit ad1db8f into Khan:main May 17, 2025
4 checks passed
@bryanwweber bryanwweber deleted the fix-error-typo branch May 17, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csilvers csilvers csilvers approved these changes

@benjaminjkraft benjaminjkraft Awaiting requested review from benjaminjkraft benjaminjkraft is a code owner

@dnerdy dnerdy Awaiting requested review from dnerdy dnerdy is a code owner

@StevenACoffman StevenACoffman Awaiting requested review from StevenACoffman StevenACoffman is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bryanwweber @csilvers