feat(claw): detect image-tag-only updates and make upgrade one-click#1355
Open
feat(claw): detect image-tag-only updates and make upgrade one-click#1355
Conversation
| hasVersionInfo && | ||
| !!status.trackedImageTag && | ||
| !!latestVersion?.imageTag && | ||
| status.trackedImageTag !== latestVersion.imageTag; |
Contributor
There was a problem hiding this comment.
WARNING: Variant-unaware image-tag comparison can show a false upgrade
useKiloClawLatestVersion() ultimately reads /api/platform/versions/latest, which hard-codes the default variant. Comparing every instance's trackedImageTag against that tag means a user pinned to a non-default variant will always see Update available, and the one-click upgrade will move them back to the default image instead of the latest tag for their chosen variant. This check needs to be variant-aware (or skipped unless the variants match).
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
Reviewed by gpt-5.4-20260305 · 288,207 tokens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Visual Changes
Reviewer Notes
via useEffect in InstanceControls). This is documented with an inline comment. it won't re-fire if the flag is already
true, which is fine for a single-click flow but worth knowing
SettingsTab which already has the data. Both are react-query hooks that would share cache, but prop drilling keeps the component more presentational