fix: address PR #32 review comments on release automation#33
Merged
mikkeldamsgaard merged 1 commit intomainfrom Mar 11, 2026
Merged
fix: address PR #32 review comments on release automation#33mikkeldamsgaard merged 1 commit intomainfrom
mikkeldamsgaard merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Addresses review comments from PR #32 on the release automation: uses github.event.before SHA instead of HEAD~1 for version diffing, checks remote tags via git ls-remote before creating, and fixes the cargo check comment in the /release skill.
Changes:
- Auto-tag workflow updated to use
github.event.beforeandgit ls-remotefor robust version-bump detection and tag creation /releaseskill comment corrected from "updates Cargo.lock" to "validates the build"- CHANGELOG updated with entries for the new automation features
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/auto-tag.yml |
New workflow using github.event.before for version diff and git ls-remote for tag existence checks |
.claude/commands/release.md |
New release skill with corrected cargo check description |
CHANGELOG.md |
Added unreleased entries for auto-tag workflow and /release skill |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Auto-tag workflow: detects Cargo.toml version bump on main push, creates and pushes git tag to trigger the release workflow. Uses github.event.before for reliable diff, guards against null SHA on first push, and checks remote tags before creating. - /release Claude Code skill: guided release preparation with semver determination, confirmation phase, and PR creation. - CHANGELOG updated with new automation entries. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mikkeldamsgaard
force-pushed
the
chore/release-automation
branch
from
af47e0b to
37bbd63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.event.beforeis the null SHA (first push to main), skip version comparison instead of failinggit show.github.event.beforeSHA instead ofHEAD~1for version diff — reliably detects version bumps across multi-commit pushes and merges.git ls-remotebefore creating — handles shallow checkouts and concurrent tag creation gracefully.cargo checkcomment in/releaseskill — it validates the build, not updatesCargo.lock.Test plan
/releaseskill wording is accurate🤖 Generated with Claude Code