Add type annotations to most handler properties #3320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamjallen
added a commit
to williamjallen/CDash
that referenced
this pull request
Jan 8, 2026
The legacy BuildError and BuildFailure models are treated as if they're derived from the same parent class in the build handler, but there's no guarantee that the fields the build handler attempts to access actually exist on a particular object. This PR resolves a critical issue introduced by Kitware#3320 which causes failures when parsing builds with old style build errors.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 8, 2026
The legacy BuildError and BuildFailure models are treated as if they're derived from the same parent class in the build handler, but there's no guarantee that the fields the build handler attempts to access actually exist on a particular object. This PR resolves a critical issue introduced by #3320 which causes failures when parsing builds with old style build errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prep work for upcoming changes to the structure of some of these handler files. By allowing PHPStan to better understand the types, refactors to this critical component of CDash will be slightly safer.