Open
Conversation
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
When errors occur, a structured anonymous bug report is automatically attached to the error message. Users can copy it to clipboard from the notification center. The report includes build info (volview version, git SHA, vtk.js/itk-wasm versions), browser/OS, error stack trace, and dataset metadata (dimensions, scalar type, source format, segment groups) without exposing any patient data. Closes #854
Replace the overloaded `opts?: Error | string | MessageOptions` parameter
with a typed `ErrorOptions` bag (`{ error?, details?, persist? }`). This
eliminates type-sniffing, fixes bug report generation receiving
`[object Object]` for MessageOptions callers, and makes each call site
explicit about what it's passing.
Also moves `bugReport` from MessageOptions to the Message type since it's
generated output, not caller input. Tightens generateBugReport signature
to `(error?: Error)`. Adds store-based content assertion to the E2E test.
Chrome 137+ deprecated automatic SwiftShader fallback for WebGL. Without --enable-unsafe-swiftshader, WebGL context creation silently fails on GPU-less CI runners, causing black views and test timeouts. Also simplifies bug report generation: use raw userAgent instead of parsed browser string, inline bugReport in addError, and trim the E2E test to just verify the copy button appears.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate a structured, anonymous bug report (build info, browser, stack trace, dataset metadata) on every error and attach it to the message. Users can copy it to clipboard via a button in the notification center.
Also tightens the types of the error message options with
ErrorOptionsto avoid a type union and sniffing around withinstanceofin message.ts which was causing some errors to get unhelpfuly stringified asobject Object.closes #854