Skip to content

refactor: modernize codebase - #14

Open
vitormattos wants to merge 169 commits into
mainfrom
refactor/modernize-codebase
Open

refactor: modernize codebase#14
vitormattos wants to merge 169 commits into
mainfrom
refactor/modernize-codebase

Conversation

@vitormattos

@vitormattos vitormattos commented Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This PR adds these improvements:

  • better Telegram message templates, including placeholders for the survey question, answer, and raw value;
  • safer message rendering for both HTML and plain text modes;
  • a more reliable flow to save survey-specific plugin settings.

To support these changes, the codebase was updated and expanded with unit tests, code quality and static analysis checks (PHP CS Fixer and Psalm), API integration tests with Behat, and screenshot validation tests with Playwright.

I made smoke tests and the plugin follow working fine, sending the message to Telegram and the new fields also worked fine.

@vitormattos
feat: add namespaced message template renderer
b04698e 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
feat: add namespaced survey field value provider
36a1311 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
refactor: add legacy message renderer wrapper
96829af 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
refactor: add legacy field value provider wrapper
054ea6c 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
chore: add psr-4 autoload for plugin classes
e20c62d 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
test: extend limesurvey stubs for namespaced helpers
730fd22 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
test: allow plugin double to mock template fields
3f60bea 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
test: cover telegram template placeholders
c04a613 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
test: add survey field value provider coverage
32a9717 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
refactor: move plugin implementation to namespaced class
8b96c6f 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
refactor: add global plugin compatibility wrapper
e9b25de 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
refactor: add native php types where safe
3961c27 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
test: add app runtime stub
da97876 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
test: add plugin base stub
655f6fc 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
test: add yii stub
5e5cbfa 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
test: add survey stub
9352d61 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
test: add survey dynamic stub
f1ca3ef 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
test: add formatting options stub
eab7a7f 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
test: add survey dao stub
8594d87 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
test: add translator stub
ba4462f 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
test: add view helper stub
9dca7da 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
test: load split limesurvey stubs
aa3902a 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
test: add plugin double in support
dc15985 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
test: add telegram api stub in support
eaa9254 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
test: mirror plugin unit test layout
81d59b2 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
test: mirror survey unit test layout
95cc579 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
test: add template renderer unit test
e281be4 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
test: remove legacy flat plugin test
2c17dd7 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
test: remove legacy flat survey test
4a67a08 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
test: remove legacy plugin test double
3ea9320 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
fix: allow preview screenshot drift budget
3a352ef 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
feat: add per-target screenshot comparison settings
0877dfe 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
test: cover screenshot diff ratio tolerance
5ec0a27 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
test: cover per-target screenshot comparison config
9a496f1 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
build: add deterministic preview font packages
da164a5 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
build: lock deterministic preview font packages
715d666 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
feat: embed deterministic preview fonts
7815aba 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
style: use embedded preview font families
ae9629f 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
fix: wait for preview fonts before screenshot capture
6bade2c 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
refactor: restore global screenshot comparison rules
338c94e 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
refactor: remove per-target screenshot drift settings
ddec6d1 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
test: remove per-target screenshot config coverage
c9316c3 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
test: cover embedded preview fonts
09d7272 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
docs: refresh deterministic telegram preview screenshot
98d6dd8 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
chore: ignore integration test artifacts
5a201b6 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
build: add disposable limesurvey image
1b347df 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
build: configure disposable integration stack
cd6cfc6 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
fix: add survey plugin settings save endpoint
5c0368d 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
test: stub plugin manager runtime access
0e0e26b 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
test: stub yii client script registration
95628f5 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
test: cover survey plugin settings save workaround
cf66fb0 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
test: define integration composer project
f47deee 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
test: lock integration dependencies
98f57c3 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
test: configure behat integration suite
fe1ab5a 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
test: add plugin settings integration scenarios
b2e9d44 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
test: add plugin settings integration context
742c5dd 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
ci: add behat integration workflow
b74b7e9 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
docs: trim integration test instructions
c2f68cb 
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
vitormattos requested a review from YvesCesar August 6, 2026 00:26
@vitormattos
vitormattos marked this pull request as ready for review August 6, 2026 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YvesCesar YvesCesar Awaiting requested review from YvesCesar

Assignees

@vitormattos vitormattos

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vitormattos