Business Images Carousel #247
Conversation
Signed-off-by: IsaacPimentel73 <[email protected]>
There was a problem hiding this comment.
Just the concerns of an external contributor, but it's not a good idea to commit third-party logos to the repository without explicitly clarifying the license.
As your website is AGPL licensed, by including these logos, it looks like you're attempting redistribute these assets under AGPL as well, which obviously isn't right.
If you're certain you're allowed to use these images in this way, I'd recommend using a tool like REUSE by the FSFE for declaring the licenses properly.
This way you're explicit about the license or copyright holder of each file.
|
|
||
| <div class="slide"> | ||
| <a href="https://www.youtube.com/watch?v=3Z780EOzIQs" target="_blank"> | ||
| <img src="{{ $page->baseUrl }}assets/images/companies/empresa2.png" alt=""> |
There was a problem hiding this comment.
I would expect the alt text of each logo to be the companies name.
For example, this one would be alt="Amazon".
There was a problem hiding this comment.
If you're certain you're allowed to use these images in this way, I'd recommend using a tool like REUSE by the FSFE for declaring the licenses properly.
Excellent point!
At LibreSign we are using a REUSE GitHub Action to validate this. It's a good idea to a new PR here implementing REUSE.
There was a problem hiding this comment.
I would expect the alt text of each logo to be the companies name.
It's good to usability.
There was a problem hiding this comment.
@SethFalco I wrote a possible to-do list with steps to implement REUSE.
Automatic carousel with several companies.
