Skip to content

docs -add writeup about a dual PID axis example - #4346

Merged
grandixximo merged 1 commit into
masterfrom
dual_pid_doc
Aug 8, 2026
Merged

docs -add writeup about a dual PID axis example#4346
grandixximo merged 1 commit into
masterfrom
dual_pid_doc

Conversation

@c-morley

@c-morley c-morley commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

An example of dual PID axes in HAL

@grandixximo

Copy link
Copy Markdown
Contributor

svg fails to render on github, is it hand written?

@c-morley

c-morley commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator Author

no, exported from Dia program

@grandixximo

Copy link
Copy Markdown
Contributor

It does not look like an svg, is it encrypted or something? I opened with text editor and it does not look like any svg I have ever seen before...

@grandixximo

grandixximo commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

it is a PNG actually, I change the format, and now it opens up

image

the SVG file has the same sha256 as the PNG file, so they are byte identical, they only differ in the file extension.

@c-morley

c-morley commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator Author

Ok thanks I think this fixes it.

@grandixximo

Copy link
Copy Markdown
Contributor

I don't understand how summing the PID results in the position you want to sent the motor at.
You are running this on a machine?

@c-morley

c-morley commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator Author

@grandixximo

Copy link
Copy Markdown
Contributor

My bad, I missed the fact that it is controlling the servo in velocity mode, makes more sense now, forum feedback looks good...

Comment thread docs/src/docs.xml Outdated
Comment thread docs/src/motion/dual-pid-example.adoc
@c-morley
c-morley force-pushed the dual_pid_doc branch 2 times, most recently from 90efed1 to 86fb5cb Compare August 7, 2026 01:40
@BsAtHome

BsAtHome commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Why is there both the SVG and PNG image attached?

We should only need the SVG. Or?

@c-morley

c-morley commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator Author

Yes I could delete the png.

@grandixximo
grandixximo merged commit 79bbeb9 into master Aug 8, 2026
47 of 48 checks passed
@c-morley
c-morley deleted the dual_pid_doc branch August 8, 2026 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants