Skip to content

Conversation

@Hirogen
Copy link
Collaborator

@Hirogen Hirogen commented Jul 7, 2025

this pr introduces multi language translation

  1. Key: Classname_<type: UI|Logger<level: warn|info|error>>_MessageKey
  2. Key: CommonName_MessageKey
  3. Key:Classname_UI_ControlType<Button,Label, etc.)_ControlName

Examples:

  • Program_Logger_Error_IPCChannel_ClientError: Class: Program.cs, Type: Logger, Level Error, MessageKey: IPCChannel_ClientError
  • Program_UI_Error_ConfigFileNotFound: Class: Program.cs, Type: UI, Level Error, MessageKey: ConfigFileNotFound
  • Title_LogExpert: CommonName: Title, MessageKey: LogExpert, using this for MessageBoxes in the title

@Hirogen Hirogen linked an issue Jul 7, 2025 that may be closed by this pull request
@Hirogen Hirogen requested a review from Copilot July 8, 2025 10:59

This comment was marked as outdated.

@Hirogen Hirogen requested a review from Copilot July 9, 2025 12:46

This comment was marked as outdated.

@Hirogen Hirogen requested a review from Copilot July 10, 2025 10:29

This comment was marked as outdated.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 84 out of 107 changed files in this pull request and generated 3 comments.

Files not reviewed (19)
  • src/CsvColumnizer/Resources.Designer.cs: Language not supported
  • src/Log4jXmlColumnizer/Resources.Designer.cs: Language not supported
  • src/LogExpert.Resources/Resources.de.Designer.cs: Language not supported
  • src/LogExpert.UI/Controls/DateTimeDragControl.Designer.cs: Language not supported
  • src/LogExpert.UI/Controls/LogWindow/LogWindow.designer.cs: Language not supported
  • src/LogExpert.UI/Controls/LogWindow/PatternWindow.Designer.cs: Language not supported
  • src/LogExpert.UI/Dialogs/BookmarkCommentDlg.Designer.cs: Language not supported
  • src/LogExpert.UI/Dialogs/BookmarkWindow.Designer.cs: Language not supported
  • src/LogExpert.UI/Dialogs/ChooseIconDlg.Designer.cs: Language not supported
  • src/LogExpert.UI/Dialogs/Eminus/EminusConfigDlg.Designer.cs: Language not supported
  • src/LogExpert.UI/Dialogs/ExceptionWindow.Designer.cs: Language not supported
  • src/LogExpert.UI/Dialogs/GotoLineDialog.Designer.cs: Language not supported
  • src/LogExpert.UI/Dialogs/HighlightDialog.Designer.cs: Language not supported
  • src/LogExpert.UI/Dialogs/LogTabWindow/LogTabWindow.designer.cs: Language not supported
  • src/LogExpert.UI/Dialogs/OpenUriDialog.Designer.cs: Language not supported
  • src/LogExpert.UI/Dialogs/ParamRequesterDialog.Designer.cs: Language not supported
  • src/LogExpert.UI/Dialogs/TabRenameDialog.Designer.cs: Language not supported
  • src/RegexColumnizer/Resources.Designer.cs: Language not supported
  • src/SftpFileSystem.Resources/Resources.Designer.cs: Language not supported
Comments suppressed due to low confidence (3)

src/LogExpert/Config/ConfigManager.cs:1

  • The error message 'Access denied' is incorrect for the generic exception handler. This catch block handles all exceptions except OperationCanceledException, not just access-related errors. The original 'Unexpected error' message was more accurate.
    src/LogExpert/Config/ConfigManager.cs:1
  • Adding empty case statements for all enum values (lines 591-622) is unnecessary. The existing code pattern with only the HighlightSettings case and a default break is cleaner and more maintainable.
    src/LogExpert.UI/Dialogs/SettingsDialog.cs:1
  • The ApplyFormTitle() method is redundant as it's already called within ApplyTextResources() method at line 80. This duplicate assignment should be removed from one of the methods.

@Hirogen Hirogen merged commit 2086e73 into Development Nov 13, 2025
2 checks passed
@Hirogen Hirogen deleted the 224-multi-language-translation branch November 13, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement this will make things better Feature what a great idea

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multi Language Translation

2 participants