Update Python version requirement to <3.14#27
Conversation
Python3.13.12 support was added to StabilityMatrix within the last few releases, but ComfyUI-Inference-Core-Nodes fails to install to the package due to the current dependency requiring versions less than 3.13. I was able to install ComfyUI-Inference-Core-Nodes after modifying pyproject.toml locally to `<3.14`, and did not have any issues running `install.py` from my 3.13.12 venv after that.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the project's compatibility by expanding the supported Python version range. It specifically addresses an installation problem encountered with Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the pyproject.toml file to extend the supported Python version range to include Python 3.13. However, the reviewer noted that the onnxruntime-gpu dependency for the cuda-12 optional dependency has not been updated to include wheels for Python 3.13, which could lead to installation failures for users on that version. The reviewer suggests adding the correct onnxruntime-gpu wheels for Python 3.13 for both Windows and Linux to ensure full support.
Adds the PyPI onnxruntime-gpu packages for Windows and Linux when running Python 3.13.
Removed comma
Mojo-OG
left a comment
There was a problem hiding this comment.
Gemini code assist feedback addressed
Python3.13.12 support was added to StabilityMatrix within the last few releases, but ComfyUI-Inference-Core-Nodes fails to install to the package due to the current dependency requiring versions less than 3.13.
I was able to install ComfyUI-Inference-Core-Nodes after modifying pyproject.toml locally to
<3.14, and did not have any issues runninginstall.pyfrom my 3.13.12 venv after that.