Update namelist file to include new&missed options#900
Update namelist file to include new&missed options#900hollyhan wants to merge 2 commits intoMPAS-Dev:mainfrom
Conversation
|
@matthewhoffman & @trhille, I got to visit this while setting up new set of ISMIP6 Antarctica 2300 simulations. Let me know if there are other options to include (or remove) based on recent MALI development that would be relevant to include in this PR. |
|
This looks fine to me but I'm not really qualified to review it. @hollyhan, is there anything specific you wanted from me? If not, I'll probably remove myself as a reviewer. |
|
@hollyhan , thanks for looking at this. In general, we only include namelist options for options that are active and we want deliberately set in a way that differs from the default. I think all of the new options you added are for features that are off in this namelist, and therefore we don't need (or probably want) them introduced to the compass test case namelist. Did you run into any issues that led you to want to add them? (the patch ice option for SLM makes sense - i was just talking about the MALI namelist options) |
Thanks for clarifying, @matthewhoffman. The extra namelist options I added here were included in my original production runs for the coupled MALI-SLM paper. When setting up new runs recently, I found myself digging through my old-run folders to figure out which namelist settings I had used. Having these included in the default namelist would make reproducibility of our work easier. But if all of options I added here are disabled and thus not needed, it's probably better to clean up the namelist in my run folders rather than here (but only 'config_restore_thickness_after_advection' was turned off?) If you think none of these changes are needed, I'll create a separate PR just handling the sea level namelist. |
This PR updates the MALI namelist file in the
ismip6_runtest case to include options for new model developments (e.g., the Runge-Kutta time integration method) that have been added since the test case was originally merged.Update: I've added an update to the SLM namelist to work with the recent change in the SLM side (MALI-Dev/1DSeaLevelModel_FWTW#11).