Align CoordinateSystem coord-conversion return types with subclasses#4855
Open
Chessing234 wants to merge 1 commit into
Open
Align CoordinateSystem coord-conversion return types with subclasses#4855Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
The abstract CoordinateSystem.coords_to_point/point_to_coords (and the p2c alias) declared single-point return types (Point3D / list[ManimFloat]), but concrete implementations (Axes, NumberPlane) accept batched input and return np.ndarray. Widen the base signatures to match and drop the stale line-number TODO (ManimCommunity#4804). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #4804.
The abstract
CoordinateSystem.coords_to_point/point_to_coordsdeclared single-point return types:but the concrete implementations in
Axes/NumberPlaneaccept batched input and returnnp.ndarray(a single point or a stack of points). The base signatures — and thep2calias — are therefore inconsistent with actual behaviour, misleading type checkers and API readers.Fix
coords_to_pointinput to the same union already used byc2p, and returnnp.ndarray.point_to_coords(andp2c) to accept batched points and returnnp.ndarray.# ... line 2065TODO comment (the referenced line no longer exists).No runtime behaviour changes; annotations only.
Made with Cursor