feat(iOS): Add support for custom Mapbox style via mapboxMapStyle #18
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for passing a custom Mapbox style URI through the mapboxMapStyle configuration prop on iOS.
This brings iOS to feature parity with Android and allows React Native developers to dynamically set the Mapbox map style from JavaScript.
Currently, the iOS implementation of MapsIndoorsViewManager does not read the mapboxMapStyle value sent from React Native. As a result, developers cannot override the default Mapbox style when rendering indoor maps on iOS.
Android already supports this, so this PR ensures consistency between platforms.