MDEV-38412: fsp0fsp.cc: log unexpected table in sys tablespace #4493
Conversation
|
|
gkodinov
added
the
External Contribution
gkodinov
changed the title
gkodinov
left a comment
gkodinov
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
This is a preliminary review. In order for us to proceed with this. can you please clear up the license agreement asap?
|
Thanks for contribution. |
dr-m
left a comment
dr-m
left a comment
There was a problem hiding this comment.
This does not seem to be based on the latest 11.4 branch. Can you please git pull and git rebase again?
| let SEARCH_PATTERN=InnoDB: User table exists in the system tablespace; | ||
| let SEARCH_PATTERN=InnoDB: Found unexpected table in system tablespace \(space=0\): test\/t1; | ||
| --source include/search_pattern_in_file.inc |
There was a problem hiding this comment.
This test is failing on Microsoft Windows. I do see the expected output in
https://buildbot.mariadb.org/#/builders/234/builds/44722/steps/10/logs/mysqld_1_err_10
2026-01-12 10:11:51 0 [Note] InnoDB: Found unexpected table in system tablespace(space=0): test/t1
but I think that the regular expression is not being passed correctly. We may need to escape the backslash that will escape the PCRE special characters (). There is no need to escape /; it is not special.
I would suggest to omit the (space=0) from the error message and to simplify this regular expression accordingly.
There was a problem hiding this comment.
Thank you for notice, let me fix it.
There was a problem hiding this comment.
It should be fixed now.
But as you mentioned the error message, I use sql_print_information function, so I'm not sure if sql_print_error should be rather used - I think sql_print_information is suitable. Thank you for consideration.
Fix log message about unexpected table in system tablespace as the current message can be missleading due to still existing (but already deprecated) system tables SYS_DATAFILES and SYS_TABLESPACES, reported in - MDEV-38412 Also adding the informative message with table name of the unexpected table in system table space.
5 participants
Fix log message about unexpected table in system tablespace as the current message can be missleading due to still existing (but already deprecated) system tables SYS_DATAFILES and SYS_TABLESPACES, reported in
Also adding the informative message with table name of the unexpected table in system table space.
Basing the PR against the correct MariaDB version
mainbranch.PR quality check