MDEV-40103 Initialise thd->net in spider_create_sys_thd

[mariadb-YuchenPei]

This fixes an msan uninitialized bug

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[gemini-code-assist]

Code Review

This pull request introduces a call to my_net_init to initialize the network structure for a newly created system thread in spider_create_sys_thd. The review feedback points out that my_net_init can fail and its return value should be checked to handle failures gracefully, preventing potential crashes or undefined behavior.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[mariadb-YuchenPei]

/gemini review

[gemini-code-assist]

Code Review

This pull request adds network initialization to the system thread creation process in spider_create_sys_thd by calling my_net_init and handling its failure. The feedback suggests improving code style and readability by replacing the explicit cast (st_vio*) 0 with NULL and fixing a minor spacing issue in the function call.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[mariadb-YuchenPei]

/gemini review

[gemini-code-assist]

Code Review

This pull request updates spider_create_sys_thd in storage/spider/spd_table.cc to initialize the network buffer of the newly created thread using my_net_init. If the initialization fails, the thread is properly destroyed and NULL is returned. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[grooverdan]

Just improved commit messgage.

net is used by THD::print_aborted_warning when threads are killed so this needed to be initalized.

[mariadb-YuchenPei]

Just improved commit messgage.

net is used by THD::print_aborted_warning when threads are killed so this needed to be initalized.

Thanks, done